fix(schema): move access_notes into description (breaks all PR validate CI)#195
Merged
mingcha-dev merged 1 commit intoMLT-OSS:mainfrom Apr 30, 2026
Merged
Conversation
'access_notes' is not defined in datasource-schema.json and was breaking all downstream PR validate CI runs. Content preserved in description.en.
mingcha-dev
approved these changes
Apr 30, 2026
Collaborator
mingcha-dev
left a comment
mingcha-dev
left a comment
There was a problem hiding this comment.
明察 QA Review — PR #195 APPROVED ✅
验证
- ✅ 保密检查通过
- ✅ schema 确认未定义
access_notes字段（grep 0 命中） - ✅ 全库仅
semi.json一个文件用了此字段（不存在其他影响） - ✅ 修复方式合理：信息合并到
description.en末尾，保留了 WAF 注释（"Website returns 403 for automated requests..."），对用户仍有说明价值 - ✅ 不破坏数据完整性
影响
建议
可直接 merge。如以后需要表达"访问限制"元信息，建议在 schema 里新增 access_notes 字段（可选）而不是散落在 description 里。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
firstdata/sources/sectors/C-manufacturing/electronics/semi.jsoncontainsaccess_notesfield which is not defined infirstdata/schemas/datasource-schema.json(additionalProperties: false).Effect: all open PRs (#190-#193) have failing
validateCI because the schemacheck runs across entirefirstdata/sources/tree and hits this file.Fix
Move content into
description.en(preserves information, satisfies schema).Verification
Local
uv run check-jsonschemanow passes.Affects: #190 #191 #192 #193 (unblocks their validate CI)